feat: implement initialize and execute states within update run #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
britaniar
force-pushed
the
startStopImplementation
branch
2 times, most recently
from
07c7ac6 to
6a68b64
Compare
Copilot finished reviewing on behalf of
ryanzhang-oss
November 25, 2025 23:54
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the Start/Stop API for update runs, introducing state-based control over update run execution. The changes enable users to create update runs in a NotStarted state, transition them to Started to begin execution, Stopped to pause, and Abandoned to terminate. Key changes include:
- Updated the updateRun controller to use
Statefrom the Spec to determine execution flow - Modified conditional checks to disregard generation for immutable fields (only State changes)
- Refactored
executeUpdatingStageinto smaller helper methods to reduce complexity - Added comprehensive integration and E2E tests for state transitions
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/controllers/updaterun/controller.go | Added state-based execution control with early checks for Abandoned/Stopped states; modified initialization logic to ignore generation changes |
| pkg/controllers/updaterun/execution.go | Refactored executeUpdatingStage into smaller helper methods; removed generation checks from condition evaluations |
| pkg/controllers/updaterun/validation.go | Updated condition checks to be generation-independent for succeeded/failed states |
| pkg/utils/condition/reason.go | Added new condition reasons: UpdateRunPausedReason and UpdateRunAbandonedReason |
| test/e2e/staged_updaterun_test.go | Updated all createStagedUpdateRunSucceed calls to include state parameter; added comprehensive E2E test for state transitions |
| test/e2e/cluster_staged_updaterun_test.go | Updated all createClusterStagedUpdateRunSucceed calls to include state parameter; added E2E test for cluster-scoped state transitions |
| test/e2e/actuals_test.go | Added helper functions for validating NotStarted, Stopped, and Abandoned states; refactored status building logic |
| pkg/controllers/updaterun/*_integration_test.go | Updated test helpers to use reason strings; added integration tests for NotStarted/Stopped/Abandoned states |
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
britaniar
force-pushed
the
startStopImplementation
branch
2 times, most recently
from
7d2cf9e to
c88d0d0
Compare
britaniar
changed the title
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
britaniar
force-pushed
the
startStopImplementation
branch
from
be4dba0 to
b44f61f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
Update the update run controller to use State from the Spec to determine whether to Initialize or Execute.
Update Initialized condition to use
Unknownstatus as it starting to initialize and have the update run status reflect that.Updated conditional checks to disregard generation checks as update run is immutable but the State field.
Added/update integrations tests and e2e tests.
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
This change covers when update run starts as state
Initializethen toExecuteor starts at stateExecute.The initialized condition should be successfully initialized once. Therefore, the generation should always be 1 for update runs
Initializedcondition.Generation will change each time update run state is updated and only when the state is updated. The rest of update run spec is immutable. Can correlate generation with state change.